overview: Clean up overview code

The comment here is a liar. We certainly can handle failure
using _syncInputMode().

https://bugzilla.gnome.org/show_bug.cgi?id=688589

diff --git a/js/ui/overview.js b/js/ui/overview.js
index da4dbae149b99014c6cc5d832e452408e7451918..7780e8263dfe25ed7095dc4dec3f993eba50e9a8 100644 (file)
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -434,12 +434,11 @@ const Overview = new Lang.Class({
             return;
         if (this._shown)
             return;
-        // Do this manually instead of using _syncInputMode, to handle failure
-        if (!Main.pushModal(this._group, { keybindingMode: Main.KeybindingMode.OVERVIEW }))
+        this._shown = true;
+        this._syncInputMode();
+        if (!this._modal)
             return;
-        this._modal = true;
         this._animateVisible();
-        this._shown = true;
     },
 
     fadeInDesktop: function() {